[jira] [Commented] (HIVE-12685) Remove invalid property in common/src/test/resources/hive-site.xml

[Mohit Sabharwal (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062703#comment-15062703
 ] 

Mohit Sabharwal commented on HIVE-12685:
----------------------------------------

Thanks, [~wzheng]

I think "javax.jdo.option.ConnectionDriverName" cannot be used instead of 
"test.property1", because that testcase is about using a property only defined 
in hive-site.xml. But "javax.jdo.option.ConnectionDriverName" is defined in 
ConfVar, no ?

Looks like there are three testcases: 

1) Override a property defined in ConfVar in data/conf/hive-site.xml:
We can choose a dummy property defined in ConfVar like:
{code}
    // ConfVar overridden in in hive-site.xml
    checkHadoopConf(ConfVars.HIVETESTMODEDUMMYSTATAGGR.varname, null);
    checkConfVar(ConfVars.HIVETESTMODEDUMMYSTATAGGR, "");
    checkHiveConf(ConfVars.HIVETESTMODEDUMMYSTATAGGR.varname, "test");
{code}

And we can override it in data/conf/hive-site.xml:
{code}
+ <property>
+  <name>hive.test.dummystats.aggregator</name>
+  <value>test</value>
+ </property>
{code}

2) Property only defined in hive-site (but not in ConfVar or hadoop conf):

{code}
    // Property defined in hive-site.xml only
    checkHadoopConf("test.property1", null);
    checkHiveConf("test.property1", "hive-site.xml");
{code}

For this, we can move test.property1 from 
common/src/test/resources/hive-site.xml to data/conf/hive-site.xml 

3) Test HiveConf property variable substitution in hive-site.xml

For this, we can also move test.var.hiveconf.property from 
common/src/test/resources/hive-site.xml to data/conf/hive-site.xml  as you did 
in your latest patch.

Let me know if this makes sense or I'm missing something.

> Remove invalid property in common/src/test/resources/hive-site.xml
> ------------------------------------------------------------------
>
>                 Key: HIVE-12685
>                 URL: https://issues.apache.org/jira/browse/HIVE-12685
>             Project: Hive
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Wei Zheng
>            Assignee: Wei Zheng
>         Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch, 
> HIVE-12685.3.patch, HIVE-12685.4.patch
>
>
> Currently there's such a property as below, which is obviously wrong
> {code}
> <property>
>   <name>javax.jdo.option.ConnectionDriverName</name>
>   <value>hive-site.xml</value>
>   <description>Override ConfVar defined in HiveConf</description>
> </property>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)