mattcasters opened a new pull request, #7718: URL: https://github.com/apache/hop/pull/7718
## Summary Fixes marketplace install failures on Windows when activating plugins that ship shared jars under `lib/core/` (e.g. `hop marketplace install hop-tech-parquet` failing on a locked `avro-1.12.1.jar`). Windows keeps exclusive locks on jars already on the Hop system classpath (`lib/core/*`). After #7666, marketplace activation always used `Files.copy(..., REPLACE_EXISTING)`, which fails when the target is locked and aborts the whole install. ### Behavior | Situation | Result | |-----------|--------| | `lib/core` jar **missing** | Still installed (keeps #7666) | | `lib/core` jar **identical** | Skip copy (all platforms) | | `lib/core` jar **different**, Windows | Leave existing; log; continue install | | `lib/core` jar **different**, non-Windows | Replace as before | | Copy still fails | Soft-fail + log; do not abort plugin activation | Uninstall remains sticky for `lib/core`. README notes the Windows behavior. ## Testing - [x] `./mvnw -pl plugins/misc/marketplace test` (unit tests including identical / different shared-core cases and `skipSharedCoreCopy` rules) - [ ] **Windows 11**: with a client that already has `lib/core/avro-1.12.1.jar`, run `hop marketplace install hop-tech-parquet` — should complete; plugin under `plugins/tech/parquet` - [ ] Install a plugin whose shared jars are **not** already present (e.g. vault/Azure stack) — new jars still land under `lib/core` Fixes #7717 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
