fskorgen opened a new pull request, #8530:
URL: https://github.com/apache/hop/pull/8530
Clicking a cell in a read-only grid placed an inline editor over the value.
The editor covered the
value and took the right-click, so the grid's own context menu could not be
reached.
*Select all rows*, *Clear selection* and *Filtered selection* only read the
table — `setFilter()`
ends in `table.setSelection(...)`, and `clipSelected()` reads — but all
three were switched off with
`setEnabled(!readonly)`, together with *Copy selected lines to clipboard*. A
read-only grid could
therefore not select or copy its own rows, which is the main thing users do
with a result.
Changes in `TableView`:
- `editSelected` selects the row and returns when the grid is read-only.
- The `!readonly` gate is dropped on the four menu items above. The toolbar
already allowed these in
read-only grids (`ID_TOOLBAR_COPY_SELECTED` is gated on `linesSelected`,
the other three on
`hasRows`), so the menu and the toolbar disagreed.
- New *Copy cell value* item, backed by `clipCell()`. It takes the stored
value through
`getCellValue`, not the shortened display string, and goes through
`GuiResource.toClipboard` so it
also reaches the browser clipboard under RAP.
`ui` builds clean; the module's 577 tests pass.
Fixes #8360
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
