mattcasters opened a new pull request, #8652: URL: https://github.com/apache/hop/pull/8652
Dialogs build `TableView` grids by hand because `@GuiWidgetElement` only describes a single value. This adds a data-grid annotation for a `List` of row objects. `@GuiWidgetElement(type = TABLE)` on a `List` field, with `@GuiTableColumn` on the row class, is picked up by `GuiRegistry` and drawn by `GuiCompositeWidgets`. A column is text, an enum or string combo, or a `Y`/`N` checkbox. Enum cells use `Enum.name()`. `tableRows` sets the height the dialog opens at, and the last grid in a tab, box, or flat form grows when the dialog is resized. A `BUTTON` method that fills the list refreshes the grid when it returns, which is how a Get Fields button works. Helper buttons that are part of the grid itself are not included. The AI Provider metadata editor is the first use. `AiProvider.models` is now that grid: the role is an `AiModelRole` combo and the model name is text. The hand-built table and its extra group are gone. The role combo is read-only. A row with no model name is still dropped on save. fixes #2286 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
