mattcasters opened a new pull request, #8656:
URL: https://github.com/apache/hop/pull/8656

   Fixes #8624
   
   ### Description
   On Linux (and other platforms), the `ScrolledComposite` in 
`PipelineRunConfigurationEditor` failed to enable scrolling for engine 
configurations with many options (e.g. Beam Spark) because:
   1. Sizing used `wPluginSpecificComp.getBounds()` at initialization before 
the shell was drawn, setting min size to 0.
   2. `changeConnectionType()` never recalculated the minimum size on 
`wsPluginSpecificComp` when switching engines.
   3. `wPluginSpecificComp` had an invalid cross-composite `FormData` top 
attachment pointing to `lastControl` in `wMainComp`.
   
   ### Changes
   - Updated `GuiCompositeWidgets.updateScrolledMinSize()` to `public static` 
and automatically invoke it on the parent composite in 
`createCompositeWidgets()` and `setWidgetsContents()` when the parent is hosted 
inside a `ScrolledComposite`.
   - Cleaned up `wsPluginSpecificComp` layout in 
`PipelineRunConfigurationEditor` to use `FillLayout` and properly track dynamic 
min size via `computeSize()`.
   - Added a unit test in `GuiCompositeWidgetsGroupTest` verifying automatic 
min-size updates for flat widgets in a `ScrolledComposite`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to