mattcasters opened a new pull request, #8805: URL: https://github.com/apache/hop/pull/8805
Opening a pipeline or workflow context menu asked `getInstance()` for the filter class. For hop and transform filters that class is the graph, and `getInstance()` only returns the active tab. The SWTBot click tests drive a canvas that is not the active file, so the plugin was null. The failure was caught and logged, with a full stack trace, once per action. The filter id made it worse: it was built with `guiPluginClassName.getClass().getName()`, and that value is already a `String`, so every line said `java.lang.String.<method>`. Filters and action callbacks now use the graph the context already holds when that graph owns the method. Other plugins still use `getInstance()`. A filter that cannot be created is logged once, and its actions stay visible. A null plugin is rejected when the action is built, instead of failing later inside the lambda. fixes #8804 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
