bamaer commented on PR #8805:
URL: https://github.com/apache/hop/pull/8805#issuecomment-6096334779
**Should fix**
- **Most of this already landed in #8716.** Main's ui-tests log no longer
has the #8804 errors (run on `4940b06181`: 0 "Error filtering out action"
lines, 46/46 tests in `HopGuiPipelineGraphClickContractTest`). 5 of the 6 tests
in `BaseGuiContextHandlerFilterTest` already pass on current main
(`620b8c55bd`); only `brokenFilterIsPreparedOnceForEveryAction` fails. Suggest
cutting the PR down to what's new:
- the `GuiActionLambdaBuilder` change and its test;
- the load-once filter resolution in `BaseGuiContextHandler`, if you want
to keep it.
Then drop the rest:
- the `GuiRegistry` comments (lines 549 and 795), which describe a
`getClass()` call that is no longer there;
- `pluginInstanceFromContext`, which repeats what `pluginFromMethod`
already does through `getPipelineGraph()` / `getWorkflowGraph()`;
- the tests that repeat #8716's `BaseGuiContextHandlerTest`.
The PR description should also say that the filter id and null-plugin
parts are already fixed on main.
Code reviewed; ran the new filter tests against current main. Did not run
the full PR build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
