mattcasters opened a new pull request, #8927: URL: https://github.com/apache/hop/pull/8927
Keeps the OpenFormula engine and replaces the tests that came with it. Those tests were the old formula suite: `FormulaTestBase`, the `Prd*` classes, and 74 files that still named the original authors. They are deleted. Nothing under `src/test` still contains `@author`, `FormulaTestBase`, or `Prd5174`. The new cases follow OASIS OpenDocument v1.2 Part 2 (29 September 2011). Each Part 2 function the engine registers has one case, and a coverage test fails if a registered function is neither in that set nor in the Kettle/PDI extra set. The extras (`BEGINSWITH`, the array helpers, `YESTERDAY`, and the rest) are tested from their own descriptions, not from Part 2. `DAYS(EndDate; StartDate)` subtracted the arguments in the other order. It now returns EndDate minus StartDate, which is what Part 2 section 6.10.6 specifies for numeric dates. The clean-room sentence is removed from `NOTICE`. That file is for required attributions, and the engine has none. This supersedes #8926. Please do not merge that revert. It would delete the engine as well as the tests. fixes #8907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
