leehaut opened a new pull request, #8933:
URL: https://github.com/apache/hop/pull/8933
## Summary
Workflow Check (F7) on the Delete files action passed each row's file path
to `validate()` as the property name. The validator looks that name up on the
action bean, so a path such as
`${Internal.Entry.Current.Directory}/files/dummy.csv` failed with `Unable to
validate. Reason: <path>` and the file was never checked.
`ActionDeleteFiles.check()` now validates `fileItems[i].fileName` and
resolves variables from the workflow variable space passed into Check.
## Test plan
- [x] Open a workflow whose Delete files action lists
`${Internal.Entry.Current.Directory}/files/dummy.csv` (or any non-blank path)
and press F7. The Check tab must not show `Unable to validate. Reason:`
followed by that path.
- [x] Leave the file name blank and press F7. The remark should name
`fileItems[0].fileName`, not a path string.
- [x] `mvn -pl plugins/actions/deletefiles test
-Dtest=ActionDeleteFilesCheckTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
