bamaer commented on PR #8980:
URL: https://github.com/apache/hop/pull/8980#issuecomment-6230833210

   Thanks @Adalennis, this makes the template usable as is. I checked the 
attributes, title, first rows and comments against the existing transform and 
action pages, the description check in the docs PR build and the hop-website 
README; it all matches. Not rendered, since the template isn't published.
   
   One small suggestion: for a transform, the copy instructions could also 
mention adding the page to the list in `pages/pipeline/transforms.adoc`, not 
just `nav.adoc`. That list has drifted (248 of 279 transform pages; e.g. 
`watchfiles` and `extractgraph` are missing).
   
   LGTM otherwise.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to