bamaer commented on PR #9047: URL: https://github.com/apache/hop/pull/9047#issuecomment-6307929649
Thanks @Adalennis, checked every Result row against `execute()` on main (code read, not run). Docs-only, so nothing here blocks; two Unzip rows don't match the code. **Worth fixing** 1. **Unzip, *Get args from previous*, row with one field.** The NPE from `resultRow.getString(1, null)` (`ActionUnZip.java:333`) is caught by the `catch` around the whole row loop (`:384`). So it doesn't only skip that zip file: none of the rows after it are processed either. Suggest: "A row with only one field counts as one error and stops the action: the zip files of that row and the rows after it are not unzipped." Worth adding to #9049 point 1 as well. 2. **Unzip note, *Nr errors less than*.** "Still true when the number of errors equals *Limit files*" only holds for files in a folder, or when the last row reaches the limit. With *Get args from previous*, reaching the limit while more rows follow returns false straight away (`ActionUnZip.java:318-326`), the same as the Delete folders note says. Suggest reusing that wording for result rows. Minor: "when the folder for *Move files* doesn't exist" → "...doesn't exist and its *Create folder* is not selected." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
