bamaer commented on PR #9054: URL: https://github.com/apache/hop/pull/9054#issuecomment-6308184347
Thanks @leehaut. Built and tested locally: the textfile plugin tests all pass, and against main's `TextFileOutput` the new `TextFileOutputEncodingTest` fails 16 cases (e.g. 12 byte order marks instead of 1), so it covers the bug well. I also read through split files, file name in field with reopened files, and append: the mark is only written when a new file is opened. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
