Adalennis opened a new pull request, #9222:
URL: https://github.com/apache/hop/pull/9222
Fixes #9048
Three fixes on
pipeline/pipeline-run-configurations/beam-flink-pipeline-engine.adoc:
- Flink version: the page said Apache Flink 1.13. The Beam plugin uses
beam-runners-flink-1.19, and the compatibility table in Getting started with
Apache Beam says Flink 1.19.x, so the page now says 1.19 and links to that
table.
- Flink job ID: the "Job id" and "Flink job ID" sections contradicted each
other, each being right only for some Flink masters. They are now one section,
checked against BeamFlinkPipelineEngine: Hop chooses and reports the job ID
(getFlinkJobId(), the pipeline log and the flink.job.id execution detail) when
the Flink master is [local] or host:port. With [auto], also used for an empty
master, Flink takes its environment from `flink run` or the Kubernetes operator
and ignores that ID, and [collection] doesn't submit a cluster job, so there is
no ID: the job can be found by its Beam job name, which Hop derives from the
pipeline name. The Dataflow note (dataflow.job.id) is kept.
- Options table: removed the Javadoc leftovers in Execution retry delay ("A
value of {@code -1}") and Batch execution mode ("Reference {@link
...ExecutionMode}").
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
