bamaer commented on PR #9329: URL: https://github.com/apache/hop/pull/9329#issuecomment-6693452950
Thanks @mattcasters, this covers both points from the #9244 review. Checked: built the annotation plugin and ran its tests, 28/28 green. With the pre-PR code the new tests fail (6 failures: the three press-flag tests and the 0.5x/2x size checks), so both fixes are covered. `SwtGc` and `SvgGc` both scale in `setTransform`, and the callout is painted inside that transform, so dropping the extra scale is right for the desktop GUI and Hop Web. LGTM. Code reviewed and unit tests run; not clicked through in Hop GUI or Hop Web. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
