bamaer commented on PR #9331:
URL: https://github.com/apache/hop/pull/9331#issuecomment-6693589267

   Thanks @hansva, LGTM.
   
   Checked locally:
   - `RowsToResultTest` passes 5/5. With main's `RowsToResult.java`, the 
in-place change and single-threaded tests fail (`[changed downstream, ...]` and 
`[]`).
   - `main-0004-rows-to-result` (single_threaded IT project) exits with 1 on 
main's plugin jar and 0 with this PR.
   
   Minor: `severalCopiesLoseNoRows` also passes on main (10/10 attempts), so it 
doesn't reproduce the race. The lock itself is fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to