leehaut opened a new pull request, #9403:
URL: https://github.com/apache/hop/pull/9403

   Fix https://github.com/apache/hop/issues/9355
   
   ## Summary
   - `hop run` implemented `Runnable`, so picocli always exited with `0` even 
when the pipeline had errors or the workflow result was false. Schedulers and 
CI that call `hop run` therefore treated failed runs as successful.
   - `HopCommandRun` now implements `Callable<Integer>` and returns `0` / `1` 
from `finishedWithoutError`, matching `HopRun.main` (`hop-run.sh` / 
`hop-run.bat`).
   - Unit test covers the `call()` return value and that 
`CommandLine.execute()` uses it.
   
   
   ## Test plan
   - [x] Unit: `HopCommandRunExitCodeTest`
   - [x] Manual: `hop run -r local -f fail-abort.hwf` → exit code `1` (was `0`)
   - [x] Manual: `hop-run -r local -f fail-abort.hwf` → exit code `1` 
(unchanged)
   - [x] Manual: successful workflow/pipeline via `hop run` still exits `0`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to