bamaer commented on PR #9403: URL: https://github.com/apache/hop/pull/9403#issuecomment-6772392803
Thanks @leehaut, this does what #9355 asks. picocli checks `Callable` before `Runnable`, so `call()` is used even though `HopRunBase` still implements `Runnable`. Verified: built `engine` from this PR and ran `HopCommandRunExitCodeTest` plus the existing `HopRun*` tests (34 tests, all pass). With `HopCommandRun` from main, `picocliExecuteUsesCallReturnValue` fails with `expected: <1> but was: <0>`, so the test catches the bug. Not run end-to-end on an assembled client. **Should fix** - No integration test. The unit test stops at picocli, so nothing covers the `hop` launcher → `Hop.main` → `System.exit` path that a scheduler sees. Suggestion: add a check in `integration-tests/hop_run`, next to the SIGTERM checks there. A script runs `hop run -r local -f` on a pipeline with an Abort transform and expects exit code 1, then on a passing pipeline and expects 0. Call it from a `main-0004-hop-run-exit-code.hwf`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
