williamWEWEevan opened a new pull request, #9428: URL: https://github.com/apache/hop/pull/9428
The pipeline canvas froze because opening a transform's "Output of" preview window put the graph into a locked state: HopGuiPipelineGraph set a showingOutputRows flag and then made six event handlers (mouseDown, mouseUp, mouseMove, mouseDoubleClick, menuDetect, and the preview-opening method itself) bail out immediately while that flag was set, so no click was ever recorded, no drag could start, and every second preview request was simply refused. Those guards had been added back in issue [#8595](https://github.com/apache/hop/issues/8595) stop the click that opens a preview from also being treated as a canvas gesture, but they were far broader than that protection needed to be. The graph now keeps an identity-based set of the row buffers whose preview windows are currently on screen, and only refuses a preview when that exact buffer's window is already open, while all canvas interaction keeps working. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
