hansva commented on PR #9428: URL: https://github.com/apache/hop/pull/9428#issuecomment-6821406060
Thanks for picking this up, @williamWEWEevan, and for the clear explanation of where the freeze came from! Tracking the open windows per row buffer, by identity, is a good fix for #9305. A few things before we can merge: 1. `spotless:check` fails on `HopGuiPipelineGraph.java` (the new Javadoc needs `<p>` and a shorter line). Running `./mvnw -pl ui spotless:apply` fixes it. 2. `showOutputDataDialog` keeps `synchronized (rowBuffer.getBuffer())` while the window is open, and the row samplers of a running pipeline write to that list under the same lock. That has been the case for a while, but now that the canvas stays usable and several windows can be open, a running pipeline will stall on any transform whose rows are on screen. Could you copy the rows inside the `synchronized` block and open the window on the copy, outside it? `ShowRowsDialog` reads the rows while it builds its table, so a copy is enough. 3. Because each window runs its own event loop, a second window opens inside the first one's loop. Opening A, then B, then closing A leaves A's buffer marked as open until B is closed, so clicking A's badge again does nothing. Removing the buffer when the window's shell is disposed (or opening the window without its own event loop) would fix that. 4. `showingOutputRows` is now only kept for a test. Could it go, with `assertIdle` in `HopGuiPipelineGraphOutputDataTest` checking that no buffer is marked open instead? 5. Could you add a test to `HopGuiPipelineGraphOutputDataTest` for the new behaviour: opening the rows of a second transform while the first window is up, and dragging a transform while a window is open? And a small one: please rebase on main instead of merging it into the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
