[
https://issues.apache.org/jira/browse/HTRACE-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388969#comment-14388969
]
Colin Patrick McCabe commented on HTRACE-144:
---------------------------------------------
bq. Seems strange to pass a default through headers. Why not make it part of
the request body?
It seems simpler to put it in the header. If it is in the request body, then
we have to worry about issues like: how is it specified, what's the format,
what if a second default is specified, etc. The header is for information
global to the entire request, which this certainly is. Plus, this allows
programs that don't care about the optimization to just continue sending a
series of spans just as before.
> Include IP address in span process description
> ----------------------------------------------
>
> Key: HTRACE-144
> URL: https://issues.apache.org/jira/browse/HTRACE-144
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-144.001.patch, HTRACE-144.002.patch,
> HTRACE-144.003.patch, HTRACE-144.004.patch
>
>
> Right now, we have no IP address or hostname specified in the span process
> description. So if we have 100 datanodes, the spans from all of them simply
> show up as "DataNode." Obviously this is unsatisfactory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
