[ 
https://issues.apache.org/jira/browse/HTRACE-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389721#comment-14389721
 ] 

Colin Patrick McCabe commented on HTRACE-144:
---------------------------------------------

Thanks, Abe.  From what I've read online, adding a publicly accessible 
constructor that takes no arguments should avoid the "No suitable constructor 
found for type" error [~iwasakims] was seeing.  Patch 4 adds such a 
constructor.  Unfortunately, like I said, I never was able to reproduce this 
error locally, so I can't be 100% sure, but I am maybe 95% sure.

I'm also going to file a follow-on for supporting adding hostnames to process 
IDs, as [~eclark] suggested.  It's really nice to have process ID configurable, 
because it means we can add more stuff whenever we like in a compatible fashion.

Committed to 3.2.  Thanks, all.

> Include IP address in span process description
> ----------------------------------------------
>
>                 Key: HTRACE-144
>                 URL: https://issues.apache.org/jira/browse/HTRACE-144
>             Project: HTrace
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-144.001.patch, HTRACE-144.002.patch, 
> HTRACE-144.003.patch, HTRACE-144.004.patch
>
>
> Right now, we have no IP address or hostname specified in the span process 
> description.  So if we have 100 datanodes, the spans from all of them simply 
> show up as "DataNode."  Obviously this is unsatisfactory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to