[ 
https://issues.apache.org/jira/browse/HTRACE-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598734#comment-14598734
 ] 

Colin Patrick McCabe commented on HTRACE-199:
---------------------------------------------

I guess I have a much wider monitor than most people, since for me the 
annotations actually did fit in the span details view (although with line 
wrapping...)

Anyway, the patch works for me.  I do think it's kind of frustrating to click 
on the green "annotations" button and have nothing happen when there are no 
annotations for the span.  Perhaps we could hide that button if there are no 
annotations or no span selected?

It seems a little awkward to me to separate the annotations from the other span 
information.  What if we made double clicking on a span bring up a big modal 
dialog box with all the span information?  There would be plenty of room in a 
modal dialog box for annotations...  This would also allow copying and pasting 
from that dialog box.

> gui: Improve visualization of annotations
> -----------------------------------------
>
>                 Key: HTRACE-199
>                 URL: https://issues.apache.org/jira/browse/HTRACE-199
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>         Attachments: HTRACE-199.001.patch
>
>
> * adding dots or something showing time point where timeline annotations are 
> on span widgets.
> * showing annotations in popped up table because span details view is too 
> narrow for them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to