[
https://issues.apache.org/jira/browse/HTRACE-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603411#comment-14603411
]
Colin Patrick McCabe commented on HTRACE-199:
---------------------------------------------
OK, I figured it out. When the "selected" property of a span in the resultsSet
is set-- even if it's being set to the same value it already has-- it triggers
a "render" operation on the canvas. The render operation disrupts any
double-click operation that is in progress. This only happens for the original
spans (i.e. not the ones produced by hitting up arrow or down arrow) since only
they are in the resultsSet. This is part of the backbone.js machinery--
basically, the idea is that by redrawing the view when your model changes, they
are making life simpler for you. In this case, it actually makes life a little
more complex (welcome to frameworks...)
We can avoid this problem by only setting the "selected" property of the span
when needed. So if it is already selected, we simply don't call "set". This
allows double clicking to work for both original spans and new spans.
I attached a patch 003 that fixes this. Take a look.
I also added "$("#resultsCanvas").off" event de-registration for mouseout,
dblclick, and contextmenu in {{SearchResultsView#remove}}. We missed removing
these earlier (all registered events should be de-registered when the view is
destroyed)
> gui: Improve visualization of annotations
> -----------------------------------------
>
> Key: HTRACE-199
> URL: https://issues.apache.org/jira/browse/HTRACE-199
> Project: HTrace
> Issue Type: Improvement
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Attachments: HTRACE-199.001.patch, HTRACE-199.002.patch,
> HTRACE-199.003.patch
>
>
> * adding dots or something showing time point where timeline annotations are
> on span widgets.
> * showing annotations in popped up table because span details view is too
> narrow for them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
