[ 
https://issues.apache.org/jira/browse/HTRACE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945899#comment-14945899
 ] 

Colin Patrick McCabe commented on HTRACE-237:
---------------------------------------------

bq. The client.go change is done in a compatible way? The server accepts both 
formats?

It breaks the old span sending format, but since this is not in htrace-core, 
there's no compatibility guarantee.  I'd rather not carry around the 
compatibility cruft yet until we get a big userbase.

bq. So Conf is a subset of HTraceConfiguration with some extra utility with 
some JSON decoration? Conf seems like an odd name for such a beastie.

It's a common pattern in Hadoop where we want to cache things pulled out of a 
{{Configuration}} object.  One reason we do it is because accessing 
{{Configuration}} is slow (it's much slower than a normal hash table lookup) 
and we want to have configuration values in an easy-to-access form.  Another 
reason to do is so that we can effectively log what the configuration is at 
runtime.

bq. Where is the config? Is this something someone can ask for with http 
content-type?

If {{htraced.receiver.packed}} is {{false}}, we use JSON over HTTP.  If 
{{htraced.receiver.packed}} is {{true}}, we use msgpack over HRPC.

> Optimize htraced span receiver
> ------------------------------
>
>                 Key: HTRACE-237
>                 URL: https://issues.apache.org/jira/browse/HTRACE-237
>             Project: HTrace
>          Issue Type: Improvement
>    Affects Versions: 4.1
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-237.001.patch, HTRACE-237.002.patch, 
> HTRACE-237.003.patch, HTRACE-237.004.patch
>
>
> Optimize htraced span receiver so that it supports double buffering and both 
> the msgpack and REST transports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to