[
https://issues.apache.org/jira/browse/HTRACE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091299#comment-15091299
]
Colin Patrick McCabe commented on HTRACE-237:
---------------------------------------------
Thanks for reviewing this, [[email protected]]. Don't hesitate to
comment on old JIRAs... we can always create new issues and link them back if
we want :)
I think it might be nice to have {{BufferManager}} implement
{{java.io.Closeable}}, since maybe it would enable some static analysis tools
to complain if we somehow failed to close it (but then again, maybe not... I
haven't looked at the code closely to see if this is something a static
analyzer could figure out). We would have to add catch blocks in a few cases
since Closeable throws IOE, which is kind of annoying, but not a big deal.
I always thought of {{java.io.Flushable}} as being something that related to
buffers and streams, not so much to "manager" or higher-level objects like this
one, but certainly the type signature and semantics fit, so maybe that makes
sense as well.
Maybe we should open a small cleanup jira for this?
> Optimize htraced span receiver
> ------------------------------
>
> Key: HTRACE-237
> URL: https://issues.apache.org/jira/browse/HTRACE-237
> Project: HTrace
> Issue Type: Improvement
> Components: htraced
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 4.1
>
> Attachments: HTRACE-237.001.patch, HTRACE-237.002.patch,
> HTRACE-237.003.patch, HTRACE-237.004.patch, HTRACE-237.006.patch
>
>
> Optimize htraced span receiver so that it supports double buffering and both
> the msgpack and REST transports.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
