[
https://issues.apache.org/jira/browse/HTRACE-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002902#comment-15002902
]
Colin Patrick McCabe commented on HTRACE-297:
---------------------------------------------
This improvement took my BenchmarkDatastoreWrites benchmark from {{103127
ns/op}} to {{88156 ns/op}}.
You can test it for yourself by running:
{code}
./htrace-htraced/go/gobuild.sh test -test.run=SkipRunningTests
-test.bench=BenchmarkDatastoreWrites -cpu 16 -benchtime=1m
{code}
> htraced: avoid serializing spans to json unless TRACE logging is enabled
> ------------------------------------------------------------------------
>
> Key: HTRACE-297
> URL: https://issues.apache.org/jira/browse/HTRACE-297
> Project: HTrace
> Issue Type: Bug
> Components: htraced
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
>
> We have been unconditionally serializing spans to JSON, but only logging them
> when TRACE logging is enabled. Profiling has revealed that this is a CPU
> bottleneck. Let's put "if" statement guards around the log messages to avoid
> doing this serialization unless it is really useful.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
