[
https://issues.apache.org/jira/browse/HTRACE-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002957#comment-15002957
]
stack commented on HTRACE-297:
------------------------------
Looks good. +1. Changes in
b/htrace-htraced/go/src/org/apache/htrace/htraced/datastore_test.go
intentional? New heartbeat interval and stripping port?
> htraced: avoid serializing spans to json unless TRACE logging is enabled
> ------------------------------------------------------------------------
>
> Key: HTRACE-297
> URL: https://issues.apache.org/jira/browse/HTRACE-297
> Project: HTrace
> Issue Type: Bug
> Components: htraced
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-297.001.patch
>
>
> We have been unconditionally serializing spans to JSON, but only logging them
> when TRACE logging is enabled. Profiling has revealed that this is a CPU
> bottleneck. Let's put "if" statement guards around the log messages to avoid
> doing this serialization unless it is really useful.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
