[ 
https://issues.apache.org/jira/browse/HTRACE-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003669#comment-15003669
 ] 

Hudson commented on HTRACE-297:
-------------------------------

SUCCESS: Integrated in HTrace-Master #206 (See 
[https://builds.apache.org/job/HTrace-Master/206/])
HTRACE-297. htraced: avoid serializing spans to json unless TRACE (cmccabe: rev 
b94898e67b659acdae78e674775539344598c8ca)
* htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go
* htrace-htraced/go/src/org/apache/htrace/htraced/datastore_test.go


> htraced: avoid serializing spans to json unless TRACE logging is enabled
> ------------------------------------------------------------------------
>
>                 Key: HTRACE-297
>                 URL: https://issues.apache.org/jira/browse/HTRACE-297
>             Project: HTrace
>          Issue Type: Bug
>          Components: htraced
>    Affects Versions: 4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 4.1
>
>         Attachments: HTRACE-297.001.patch
>
>
> We have been unconditionally serializing spans to JSON, but only logging them 
> when TRACE logging is enabled.  Profiling has revealed that this is a CPU 
> bottleneck.  Let's put "if" statement guards around the log messages to avoid 
> doing this serialization unless it is really useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to