nastra commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1355016941
##########
.palantir/revapi.yml:
##########
@@ -866,6 +866,15 @@ acceptedBreaks:
old: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
new: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
justification: "Static utility class - should not have public
constructor"
+ "1.4.0":
Review Comment:
we usually try to avoid adding API-breaking changes by introducing a default
implementation as described in
https://github.com/apache/iceberg/blob/a3aff95f9e60962240b94242e24a778760bdd1d9/CONTRIBUTING.md#adding-a-default-implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
