pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1355087396
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -533,6 +533,116 @@ public void testMaxPlanningSnapshotCount() throws
Exception {
thirdResult, snapshot1, snapshot2,
ImmutableSet.of(dataFile2.path().toString()));
}
+ @Test
+ public void testTableScanNoStats() throws Exception {
+ appendTwoSnapshots();
+
+ ScanContext scanContext =
+ ScanContext.builder()
+ .includeColumnStats(false)
+
.startingStrategy(StreamingStartingStrategy.TABLE_SCAN_THEN_INCREMENTAL)
+ .build();
+ ContinuousSplitPlannerImpl splitPlanner =
+ new ContinuousSplitPlannerImpl(tableResource.tableLoader().clone(),
scanContext, null);
+
+ ContinuousEnumerationResult initialResult = splitPlanner.planSplits(null);
+ Assert.assertEquals(1, initialResult.splits().size());
Review Comment:
This is a few new test in a test class where different assertion methods are
used. I think we should migrate them in one PR, and until that stick to the
style which is used in the actual test.
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java:
##########
@@ -191,6 +192,11 @@ public DataFile copy() {
throw new UnsupportedOperationException("Not implemented: copy");
}
+ @Override
+ public DataFile copyWithSpecificStats(Collection<Integer> statsToKeep) {
Review Comment:
Yeah.. removed.
Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
