nastra commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1355020627
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -533,6 +533,116 @@ public void testMaxPlanningSnapshotCount() throws
Exception {
thirdResult, snapshot1, snapshot2,
ImmutableSet.of(dataFile2.path().toString()));
}
+ @Test
+ public void testTableScanNoStats() throws Exception {
+ appendTwoSnapshots();
+
+ ScanContext scanContext =
+ ScanContext.builder()
+ .includeColumnStats(false)
+
.startingStrategy(StreamingStartingStrategy.TABLE_SCAN_THEN_INCREMENTAL)
+ .build();
+ ContinuousSplitPlannerImpl splitPlanner =
+ new ContinuousSplitPlannerImpl(tableResource.tableLoader().clone(),
scanContext, null);
+
+ ContinuousEnumerationResult initialResult = splitPlanner.planSplits(null);
+ Assert.assertEquals(1, initialResult.splits().size());
Review Comment:
it would be better to use AssertJ-style assertions for newly added code as
that makes migrating away from JUnit4 easier. See also
https://github.com/apache/iceberg/blob/a3aff95f9e60962240b94242e24a778760bdd1d9/CONTRIBUTING.md#assertj.
That particular check would then be
`assertThat(initialResult.splits()).hasSize(1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
