danielcweeks commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359638251
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
@Override
public List<Long> splitOffsets() {
- if (splitOffsetList == null && splitOffsets != null) {
- this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
- }
-
- return splitOffsetList;
+ return splitOffsets == null ? ImmutableList.of() :
Longs.asList(splitOffsets);
Review Comment:
I think we might want to return null in the event there are no split
offsets. That looks like the original behavior, and I think most of the checks
are looking for Noel to decide between offset planning and basic split planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
