bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359633367
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -476,7 +472,7 @@ long[] splitOffsetArray() {
@Override
public List<Integer> equalityFieldIds() {
- return ArrayUtil.toIntList(equalityIds);
+ return equalityIds == null ? ImmutableList.of() : Ints.asList(equalityIds);
Review Comment:
Using the same Guava wrapper here as well. This is a slight change in
behavor as you can't add elements to the resulting list, but I didn't find
instances where the list needed to be mutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
