RussellSpitzer commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359918684
##########
core/src/test/java/org/apache/iceberg/TestManifestReader.java:
##########
@@ -41,6 +44,12 @@ public static Object[] parameters() {
return new Object[] {1, 2};
}
+ private static final RecursiveComparisonConfiguration FILE_COMPARISON_CONFIG
=
+ RecursiveComparisonConfiguration.builder()
+ .withIgnoredFields(
+ "dataSequenceNumber", "fileOrdinal", "fileSequenceNumber",
"fromProjectionPos")
Review Comment:
So this will compare split offsets now?
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -127,6 +129,7 @@ public class TableTestBase {
.withFileSizeInBytes(10)
.withPartitionPath("data_bucket=3") // easy way to set partition
data for now
.withRecordCount(1)
+ .withSplitOffsets(ImmutableList.of(4L, 10_000_000L, 20_000_000L))
Review Comment:
Minor comment but can we make the splits unique? Just want to make sure
things will break in an obvious way if they are not matching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
