mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1401664349
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
Isn't the this `Struct` method supposed to return a hashmap ? The StructType
for iceberg requires a NestedField with the id and value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
