liurenjie1024 commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1405571325
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
Yes, after removing this, directly ser/de from json no longer works. The
correct way to do this is to ser/de is using the ser/de module, you can see
[this
method](https://github.com/apache/iceberg-rust/blob/28d7006ba3af12b1f99dc078780b08ccdd8e93b1/crates/iceberg/src/spec/values.rs#L1654)
as example. It delegates ser/de to serializaiton/deserialization system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
