liurenjie1024 commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1402858796
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
> The Struct only has the field vector, I removed field_ids and field_names.
I looked at try_from_json but I still couldn't figure out how to infer the
schema from the Struct.
Sorry for the confusion, I mean this method should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
