pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410792115
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -328,6 +346,14 @@ private void setHmsTableParameters(
Set<String> obsoleteProps,
boolean hiveEngineEnabled,
Map<String, String> summary) {
+
+ setHmsParameters(
Review Comment:
I think both moving before, and after is a change in behaviour.
With the current code, the user could remove any props, expect the
`TABLE_TYPE_PROP`, `METADATA_LOCATION_PROP`, `PREVIOUS_METADATA_LOCATION_PROP`
and schema. (Not sure why UUID is removable - CC: @flyrain)
If we put the obsolate before, then none of them is removable, if we put
obsolate after, then all of them is removable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
