nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1411677311
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -328,6 +346,14 @@ private void setHmsTableParameters(
Set<String> obsoleteProps,
boolean hiveEngineEnabled,
Map<String, String> summary) {
+
+ setHmsParameters(
Review Comment:
I thought to handle the `obsolete` check at
[abstract](https://github.com/apache/iceberg/pull/8907/files#diff-5ecfc223b311b523a12be7482b6235318fdd7535c371f899daf7e09eacddad77R201)
level too. Please share your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
