rdblue commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1414716052
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -168,6 +154,11 @@ public String name() {
return name;
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ return HiveCatalogUtil.isTableWithTypeExists(clients, identifier,
TableType.EXTERNAL_TABLE);
Review Comment:
While it is a common Java convention to put "is" at the start of any method
returning a boolean, we don't follow that in this project because it creates
really awkward method names like this one. Instead, we use names that make
sense when read, like `tableWithTypeExists` or `tableExistsWithType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
