rdblue commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1414721657
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -264,6 +269,162 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ @Override
+ public boolean viewExists(TableIdentifier identifier) {
+ return HiveCatalogUtil.isTableWithTypeExists(clients, identifier,
TableType.VIRTUAL_VIEW);
Review Comment:
What is the rationale for storing an Iceberg view as a VIRTUAL_VIEW type?
Shouldn't we just use a different `table_type` property like `iceberg-view`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
