rdblue commented on code in PR #9230:
URL: https://github.com/apache/iceberg/pull/9230#discussion_r1417822086


##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -187,8 +187,7 @@ protected void cleanUncommitted(Set<ManifestFile> 
committed) {
           deleteFile(manifest.path());
         }
       }
-
-      this.newManifests = committedNewManifests;
+      this.newManifests = null;

Review Comment:
   I doubt that this is the correct fix. I don't think that `newManifests` 
should be modified at all. What was the issue with leaving them as-is?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to