rdblue commented on code in PR #9230: URL: https://github.com/apache/iceberg/pull/9230#discussion_r1417820651
########## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ########## @@ -313,6 +313,37 @@ public void testRecoveryWithoutManifestList() { metadata.currentSnapshot().allManifests(FILE_IO).contains(newManifest)); } + @Test + public void testRecoveryWithManualReCommit() { + TestTables.TestTableOperations ops = table.ops(); + ops.failCommits(5); + + AppendFiles append = table.newFastAppend().appendFile(FILE_B); + Snapshot pending = append.apply(); + ManifestFile newManifest = pending.allManifests(FILE_IO).get(0); + Assert.assertTrue("Should create new manifest", new File(newManifest.path()).exists()); + + Assertions.assertThatThrownBy(append::commit) + .isInstanceOf(CommitFailedException.class) + .hasMessage("Injected failure"); Review Comment: Looks like this is likely failing the style checks. You can run `./gradlew spotlessApply` to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org