jasonf20 commented on code in PR #9230:
URL: https://github.com/apache/iceberg/pull/9230#discussion_r1417960440
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -187,8 +187,7 @@ protected void cleanUncommitted(Set<ManifestFile>
committed) {
deleteFile(manifest.path());
}
}
-
- this.newManifests = committedNewManifests;
+ this.newManifests = null;
Review Comment:
No issue when using a transaction, but without a transaction the commit
passes and leaves the table in an invalid (the manifest file is deleted and
can't be read) state. I changed the test to use a transaction and reverted this
change. But this leaves the non-transaction use case unsolved for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
