jasonf20 commented on code in PR #9230:
URL: https://github.com/apache/iceberg/pull/9230#discussion_r1419551515
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -313,6 +313,37 @@ public void testRecoveryWithoutManifestList() {
metadata.currentSnapshot().allManifests(FILE_IO).contains(newManifest));
}
+ @Test
+ public void testRecoveryWithTransaction() {
Review Comment:
I had a test and fix for FastAppend that failed in my first commit. It only
fails when not using a transaction.
Based on Ryan's comments in slack I removed that for now (though it's still
a bug since it can break the table) but still added a new test to cover the
case with a transaction that wasn't covered before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
