mas-chen commented on code in PR #9346:
URL: https://github.com/apache/iceberg/pull/9346#discussion_r1433194420
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java:
##########
@@ -94,7 +94,7 @@ private FlinkConfigOptions() {}
public static final ConfigOption<SplitAssignerType>
TABLE_EXEC_SPLIT_ASSIGNER_TYPE =
ConfigOptions.key("table.exec.iceberg.split-assigner-type")
.enumType(SplitAssignerType.class)
- .defaultValue(SplitAssignerType.SIMPLE)
+ .defaultValue(null)
Review Comment:
If users have not opt-ed into the new feature, I would expect their SQL
queries to still work. Can you add tests to ensure that?
After some thinking, I'm totally not sure about the default change. Couldn't
it be possible to use the watermark column, without the ordered split assigner
factory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
