pvary commented on code in PR #9346:
URL: https://github.com/apache/iceberg/pull/9346#discussion_r1433654079
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java:
##########
@@ -94,7 +94,7 @@ private FlinkConfigOptions() {}
public static final ConfigOption<SplitAssignerType>
TABLE_EXEC_SPLIT_ASSIGNER_TYPE =
ConfigOptions.key("table.exec.iceberg.split-assigner-type")
.enumType(SplitAssignerType.class)
- .defaultValue(SplitAssignerType.SIMPLE)
+ .defaultValue(null)
Review Comment:
If the splits are not ordered, then we will have fluctuating watermarks. We
do not emit those, which are not in order, but beats the purpose of the whole
watermark generation feature.
Imagine a situation where we reading time series data, and read the latest
file first. Every other file will contain late data in this case, and might be
dropped.
So while technically possible, I rather not allow the users to shoot
themselves in the foot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
