rodmeneses commented on code in PR #9346:
URL: https://github.com/apache/iceberg/pull/9346#discussion_r1433249536
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java:
##########
@@ -94,7 +94,7 @@ private FlinkConfigOptions() {}
public static final ConfigOption<SplitAssignerType>
TABLE_EXEC_SPLIT_ASSIGNER_TYPE =
ConfigOptions.key("table.exec.iceberg.split-assigner-type")
.enumType(SplitAssignerType.class)
- .defaultValue(SplitAssignerType.SIMPLE)
+ .defaultValue(null)
Review Comment:
Not according to the code.
```
if (watermarkColumn != null) {
// Column statistics is needed for watermark generation
context = context.copyWithColumnStat(watermarkColumn);
SplitWatermarkExtractor watermarkExtractor =
new ColumnStatsWatermarkExtractor(icebergSchema,
watermarkColumn, watermarkTimeUnit);
emitter =
SerializableRecordEmitter.emitterWithWatermark(watermarkExtractor);
splitAssignerFactory =
new
OrderedSplitAssignerFactory(SplitComparators.watermark(watermarkExtractor));
}
```
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java:
##########
@@ -94,7 +94,7 @@ private FlinkConfigOptions() {}
public static final ConfigOption<SplitAssignerType>
TABLE_EXEC_SPLIT_ASSIGNER_TYPE =
ConfigOptions.key("table.exec.iceberg.split-assigner-type")
.enumType(SplitAssignerType.class)
- .defaultValue(SplitAssignerType.SIMPLE)
+ .defaultValue(null)
Review Comment:
cc: @pvary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
