dramaticlly commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1439989287
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void close() throws IOException {
+ super.close();
Review Comment:
I think in order to close metric reporter when cloase the catalog, it can
also be implemented to add `super.metricsReporter()` to closeableGroup on line
143, but this require to change the `BaseMetastoreCatalog.metricsReporter()`
method from private to protected.
This approach keep the `Closeable` in concrete class instead of abstract
base class, and it seem to be more aligned with how other closable are handled
in the this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
