nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1455378169
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -143,6 +142,7 @@ void initialize(
this.closeableGroup = new CloseableGroup();
closeableGroup.addCloseable(dynamo);
closeableGroup.addCloseable(fileIO);
+ closeableGroup.addCloseable(metricsReporter());
Review Comment:
I just wanted to point out that this effectively will initialize the
reporter much earlier (during catalog instantiation) than previously (during
table loading). This is probably ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
